Jorgen,
Strange... No, it does not fail. Indeed, when I tested the code in Valgrind
it complains that we are allocating 1 too many bytes to the length. Hence
why I took off the length.
Chuck
> -----Original Message-----
> From: Jorgen.Loland@stripped [mailto:Jorgen.Loland@stripped]
> Sent: Thursday, September 25, 2008 9:28 AM
> To: Chuck Bell
> Cc: commits@stripped
> Subject: Re: bzr commit into mysql-6.0-rpl branch
> (cbell:2696) Bug#39598
>
> Chuck,
>
> the code you have changed involves char[] that store backup
> file path (including file name). You have chopped the path
> length by 1... I guess the k has been removed by one of these changes.
>
> Does the test fail on your system?
>
> Chuck Bell wrote:
> > Jorgen,
> >
> > My, that is strange. I haven't changed the test or anything
> that would
> > affect the test. Indeed, the test file has .bak specified
> for all of
> > the backup images.
> >
> > The following is an excerpt from the test. As we can see,
> line #40 in
> > the test has the same name as what was specified on the BACKUP
> > DATABASE command above it.
> >
> > --echo Perform backup
> > --replace_column 1 #
> > BACKUP DATABASE bup_backupdir TO 'bup_backupdir1.bak';
> >
> > --echo Ensure backup image file went to the correct location --echo
> > $MYSQLTEST_DIR/backup/bup_backupdir.bak
> > --file_exists $MYSQLTEST_VARDIR/tmp/backup/bup_backupdir1.bak
> >
> > I ran the test on my 64-bit Ubuntu and did not see the problem. Can
> > you repeat this and perhaps send me some of the logs?
> >
> > Chuck
> >
> >
> >> With this patch, backup_backupdir.test fails on line 40 on Linux
> >> x86/64.
> >> On this line, file_exists looks for a file with name
> >> $MYSQL_VARDIR/tmp/backup/bup_backupdir1.bak. file_exists fails
> >> because the filename is "bup_backupdir1.ba" - notice the
> missing "k".
> >>
> >
> >
>
>
