Patch looks good. I have one requirement. See comment below.
--
Øystein
Chuck Bell wrote:
> #At file:///D:/source/bzr/mysql-6.0-bug-33352/
>
> 2694 Chuck Bell 2008-09-16
> BUG#33352 Backup:crash if I use old set of mysql files.
>
> The error message produced when the backup logs are missing or damaged is
> misleading. This patch changes the error to a more appropriate, instructional
> error message.
> modified:
> mysql-test/lib/mtr_report.pl
> mysql-test/r/backup_errors.result
> mysql-test/t/backup_errors.test
> sql/log.cc
> sql/share/errmsg.txt
>
> per-file messages:
> mysql-test/lib/mtr_report.pl
> Added trap for revised error message.
> mysql-test/r/backup_errors.result
> Result file with error message changes.
> mysql-test/t/backup_errors.test
> Test now produces the correct error message. Previously, the open tables method
> produced
> a generic "can't open table" message which is unclear.
> sql/log.cc
> Capture the error handler for the missing or bad backup logs, clear the old
> error, and issue the new error for the user. Previously this error was
> placed in the server log (console) but the user got a generic message which
> was misleading.
> sql/share/errmsg.txt
> Changed error message for clarity.
> === modified file 'mysql-test/lib/mtr_report.pl'
> --- a/mysql-test/lib/mtr_report.pl 2008-09-08 11:05:26 +0000
> +++ b/mysql-test/lib/mtr_report.pl 2008-09-16 18:12:28 +0000
> @@ -331,6 +331,12 @@ sub mtr_report_stats ($) {
> # backup_errors test is supposed to trigger lots of backup related errors
> ($testname eq 'main.backup_errors') and
> (
> + /Backup:/ or /Restore:/ or /Can't open the backup logs as tables/
> + ) or
> +
> + # backup_errors test is supposed to trigger lots of backup related errors
> + ($testname eq 'main.backup_errors') and
> + (
> /Backup:/ or /Restore:/ or /Can't open the backup log tables/
> ) or
>
I think you should update the entry for the old message text here
instead of adding a new entry. (I assume the old message text will not
appear anymore.
--
Øystein
