List:Commits« Previous MessageNext Message »
From:Gleb Shchepa Date:September 18 2008 12:24pm
Subject:bzr commit into mysql-5.1 branch (gshchepa:2687) Bug#26020
View as plain text  
#At file:///work/bzr/mysql-5.1-5.1.29-rc/

 2687 Gleb Shchepa	2008-09-18
      Post-push fix for bug #26020: User-Defined Variables are not consistence with columns data types.
      
      --ps-protocol problem has been fixed.
modified:
  sql/item_func.cc

per-file messages:
  sql/item_func.cc
    Added update of Item_func_set_user_var::entry->update_query_id
    for every PS execution.
=== modified file 'sql/item_func.cc'
--- a/sql/item_func.cc	2008-09-18 08:38:44 +0000
+++ b/sql/item_func.cc	2008-09-18 12:24:09 +0000
@@ -3809,7 +3809,7 @@ static user_var_entry *get_variable(HASH
 bool Item_func_set_user_var::set_entry(THD *thd, bool create_if_not_exists)
 {
   if (thd == entry_thd && entry)
-    return FALSE;
+    goto end; // update entry->update_query_id for PS
   entry_thd= thd;
   if (!(entry= get_variable(&thd->user_vars, name, create_if_not_exists)))
     return TRUE;
@@ -3818,6 +3818,7 @@ bool Item_func_set_user_var::set_entry(T
      if this variable is a constant item in the query (it is if update_query_id
      is different from query_id).
   */
+end:
   entry->update_query_id= thd->query_id;
   return FALSE;
 }

Thread
bzr commit into mysql-5.1 branch (gshchepa:2687) Bug#26020Gleb Shchepa18 Sep