List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:September 15 2008 3:31pm
Subject:RE: bzr commit into mysql-6.0-backup branch (jorgen.loland:2694)
Bug#32465
View as plain text  
STATUS
------
Patch approved. One suggestion included below.

REQUESTS
--------
None

COMMENTARY
----------
Good work.

SUGGESTIONS
-----------
1. Please remove the extra selects against the process list. They are no
longer needed.

DETAILS
-------

>  2694 Jorgen Loland	2008-09-12
>       Bug#32465 - Backup: Commit blocker does not block 
> tables in default driver

...

> === modified file 'mysql-test/t/backup_commit_blocker.test'
> --- a/mysql-test/t/backup_commit_blocker.test	2008-07-09 
> 13:37:03 +0000

...

>  #SELECT state, info FROM
>  #INFORMATION_SCHEMA.PROCESSLIST
>  #WHERE info LIKE "DELETE%";

[1] Please remove these. They are not needed now that we use debug synch
points.

Chuck

Thread
bzr commit into mysql-6.0-backup branch (jorgen.loland:2694) Bug#32465Jorgen Loland12 Sep
  • RE: bzr commit into mysql-6.0-backup branch (jorgen.loland:2694)Bug#32465Chuck Bell15 Sep