List:Commits« Previous MessageNext Message »
From:Jorgen Loland Date:September 15 2008 11:16am
Subject:bzr commit into mysql-6.0-backup branch (jorgen.loland:2697) Bug#38462
View as plain text  
#At file:///localhome/jl208045/mysql/mysql-6.0-backup-38462/

 2697 Jorgen Loland	2008-09-15
      Bug#38462 - Binlog file shows incomplete file name in online backup table.
      
      Before: Binlog file name was written with full path to 
      backup_history log. The full path could easily be more than 64 
      chars, which is the defined length of this field in the table.
      
      Now: Full path is not needed, only binlog file name.
modified:
  sql/backup/logger.h

per-file comments:
  sql/backup/logger.h
    Only write file name to backup log, not full path
=== modified file 'sql/backup/logger.h'
--- a/sql/backup/logger.h	2008-08-28 15:13:31 +0000
+++ b/sql/backup/logger.h	2008-09-15 11:16:46 +0000
@@ -257,7 +257,10 @@ void Logger::report_binlog_pos(const st_
   DBUG_ASSERT(m_state == RUNNING);
   DBUG_ASSERT(backup_log);
   backup_log->binlog_pos(pos.pos);
-  backup_log->binlog_file(pos.file);
+
+  // only record binlog filename, not full path
+  int dn_length= dirname_length(pos.file);
+  backup_log->binlog_file(pos.file + dn_length);
 }
 
 /**

Thread
bzr commit into mysql-6.0-backup branch (jorgen.loland:2697) Bug#38462Jorgen Loland15 Sep