List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:September 13 2008 6:37am
Subject:Re: bzr commit into mysql-5.1 branch (davi:2683) Bug#34306
View as plain text  
* Davi Arnaut <Davi.Arnaut@stripped> [08/09/13 04:48]:
>  2683 Davi Arnaut	2008-09-12
>       Bug#34306: Can't make copy of log tables when server binary log is enabled
>       

Please add a test case that uses prepared statements or stored
procedures or triggers and changes the log type between two executions,
or between prepare and execute, or between the time a table is
opened and the trigger is fired, or between the time a procedure
is loaded and is executed.
This test case doesn't have to use log tables -- I would like to
see that the lock is adapted on each execution, depending on the
status of the binary log, rather than once
in the parser, like it was before.

You can look at an example in the patch for Bug#26162.

What was the reason to make TL_READ_DEFAULT the first read lock?
Perhaps worth a comment.

The patch is overall OK to push, but I'd like to glance at the
test case one more time.

-- 
Thread
bzr commit into mysql-5.1 branch (davi:2683) Bug#34306Davi Arnaut13 Sep
  • Re: bzr commit into mysql-5.1 branch (davi:2683) Bug#34306Konstantin Osipov13 Sep
Re: bzr commit into mysql-5.1 branch (davi:2683) Bug#34306Davi Arnaut13 Sep