Re: bzr commit into mysql-5.0 branch (kgeorge:2672) Bug#32124

[Georgi Kodinov]

Hi Serg,

On 11.09.2008, at 20:12, Sergei Golubchik wrote:

>>      the execution of the query).
>>      Updated an obsolete related test suite (variables-big) and the  
>> code to test the
>>      result type of system variables (as per bug 74).
>
> Looks good now.
> I have a couple of questions, see below. And there's one minor problem
> with the test case.


Thanks for doing this review. I've addressed your questions (added a  
cache for the NULL values, not copying twice in ::val_str and not  
setting the decimals and max_length in fix_length_and_dec).

The new commit is at : http://lists.mysql.com/commits/53958

Best Regards,
Joro
-- 
Georgi Kodinov
Engineering Manager, MySQL Server 5.1 release

Sun Microsystems, Inc.
Plovdiv Bulgaria
Phone [phone]
Mobile [phone]
Email Georgi.Kodinov@stripped