Re: bzr commit into mysql-5.0 branch (gluh:2678) Bug#22763

[Davi Arnaut]

Konstantin Osipov wrote:
> * Konstantin Osipov <konstantin@stripped> [08/09/12 02:35]:
>> * Use libstring functions (in the strings directory) instead of
>> standard libc string functions whenever possible. For example, use
>> bfill() and bzero() instead of memset().
> 
> I actually took a look at the implementation in strings/bzero.c.
> 
> It's horrendous ;) I wonder what is going to be the impact on
> performance if we replace all bzero with memset ;)
> 

Indeed, it's horrendous.. but replacing it won't have any performance
impact, the file is not part of our build in ages :)

A lot of stuff in strings is bit rotten and should just die, my favorite
one is bmove512.c which has this very nice piece of code:

#ifdef HAVE_LONG_LONG
#define LONG ulonglong
#else
#define LONG ulonglong
#endif

And this file is able to put the Sun C compiler in a infinite loop...

Now that you bought this subject up, you are bound to review a patch of
mine that removes a bunch of this stuff..

Regards,

-- Davi