List:Commits« Previous MessageNext Message »
From:Hakan Kuecuekyilmaz Date:September 9 2008 10:54pm
Subject:Re: bzr commit into mysql-6.0-falcon branch (hky:2815)
View as plain text  
On Di, 2008-09-09 at 20:42 +0200, John H. Embretsen wrote:
> Hakan Kuecuekyilmaz wrote:
> > On Di, 2008-09-09 at 13:07 +0200, John Embretsen wrote:
> 
> [...]
> 
> >>> === renamed file
> 'mysql-test/suite/falcon_team/r/falcon_bug_24024.result' =>
> 'mysql-test/suite/falcon/r/falcon_bug_24024.result'
> >>> --- a/mysql-test/suite/falcon_team/r/falcon_bug_24024.result	2008-04-20
> 00:05:17 +0000
> >>> +++ b/mysql-test/suite/falcon/r/falcon_bug_24024.result	2008-09-09
> 08:30:18 +0000
> >>> @@ -14,10 +16,13 @@ a	b
> >>>  1	NULL
> >>>  7	NULL
> >>>  DROP TABLE t1;
> >>> -!!! Error message has to be decided.
> >>> -!!! Something like "Cannot drop locked table" or similar would be
> fine.
> >>> -!!! But never the misleading    ERROR 42S02: Unknown table 't1'
> >>> -COMMIT;
> >>> -# Switch to session default and disconnect session con1
> >>> +ERROR 42S02: Unknown table 't1'
> >>> +SHOW WARNINGS;
> >>> +Level	Code	Message
> >>> +Warning	178	Can't execute the given command because you have active
> locked tables or an active transaction
> >> Although this change is OK, I don't really like the fact that a request
> >> of never using the misleading "Unknown table" error message for this
> >> issue is removed.
> > 
> > I put back the comment.
> 
> All right.
> 
> [...]

[...]

Ok to push?

Cheers,

Hakan

-- 
Hakan Küçükyılmaz, Senior Software Engineer DBTG/MySQL +49 160
98953296
Sun Microsystems GmbH     Sonnenallee 1, DE-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer:  Thomas Schroeder, Wolfang Engels, Dr. Roland Boemer
Vorsitz d. Aufs.rat.: Martin Haering   HRB MUC 161028     49.011, 8.376

Thread
bzr commit into mysql-6.0-falcon branch (hky:2815) Hakan Kuecuekyilmaz9 Sep
  • Re: bzr commit into mysql-6.0-falcon branch (hky:2815)John Embretsen9 Sep
    • Re: bzr commit into mysql-6.0-falcon branch (hky:2815)Hakan Kuecuekyilmaz9 Sep
      • Re: bzr commit into mysql-6.0-falcon branch (hky:2815)John H. Embretsen9 Sep
        • Re: bzr commit into mysql-6.0-falcon branch (hky:2815)Hakan Kuecuekyilmaz9 Sep
          • Re: bzr commit into mysql-6.0-falcon branch (hky:2815)John Embretsen10 Sep