Hi Sergey, Mattias,
Sergey Vojtovich, 09.09.2008 14:40:
> Hi Ingo,
>
> the patch fixes the problem described by Sveta Smirnova on 15 Aug 9:03, thus
> ok to push. Though I do not think it fixes the original problem reported by
> MattiasJ.
Sergey, thanks for the review. Why do you think it's a different problem?
Mattias, can you please apply the patch on a current branch of
5.1-bugteam and check if it fixes it on your machine?
Regards
Ingo
>
> Regards,
> Sergey
>
> On Mon, Sep 08, 2008 at 07:03:34PM +0200, Ingo Struewing wrote:
>> #At file:///home2/mydev/bzrroot/mysql-5.1-bug37958/
>>
>> 2735 Ingo Struewing 2008-09-08
>> Bug#37958 - test main.plugin crash on Mac OS X when selecting from EXAMPLE
> engine.
>>
>> The problem was improper implementation of the handlerton-to-plugin
> mapping.
>> We use a fixed-size array to hold a plugin reference for each handlerton.
>> On every install of a handler plugin, we allocated a new slot of the
> array.
>> On uninstall we did not free it. After some uninstall/install cycles
>> the array overflowed. We did not check for overflow.
>>
>> One fix is to check for overflow to stop the crashes.
>>
>> Another fix is to free the array slot at uninstall and search for a free
> slot
>> at plugin install.
--
Ingo Strüwing, Database Group
Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring HRB München 161028
