List:Commits« Previous MessageNext Message »
From:Jørgen Løland Date:September 5 2008 4:04pm
Subject:Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261
View as plain text  
Rafal,

The patch looks good, but I think it would be good to add one more test 
case [1].

Requirements
1. Add test case for restore with concurrent transaction in another 
storage engine than InnoDB.

Suggestions:
1. Add comment about bug#37303 to the test comment below

[1]
Rafal Somla wrote:
> +# Note that value 'a3' inserted into t1 at the beginning of the transaction
> +# was overwritten by RESTORE command.
> +
> +INSERT INTO db.t1 VALUES ('a7');
> +INSERT INTO test.t2 VALUES ('a8');
> +
> +COMMIT;
> +
> +connection default;
> +SELECT * FROM db.t1;
> +SELECT * FROM test.t2;
> +
> +# Cleanup
> +
> +DROP TABLE test.t2;
> +DROP DATABASE db;
> +remove_file $BDIR/db.bak;

The reason why a3 is overwritten is due to Bug#37303. There should be a 
similar test with another storage engine not affected by this bug.

-- 
Jørgen Løland
Thread
bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Rafal Somla3 Sep
  • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Jørgen Løland5 Sep
  • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Øystein Grøvlen8 Sep
    • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Rafal Somla10 Sep
      • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Øystein Grøvlen11 Sep
    • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Rafal Somla11 Sep
      • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Jørgen Løland12 Sep
        • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Rafal Somla12 Sep
      • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Jørgen Løland12 Sep
        • Re: bzr commit into mysql-6.0-backup branch (rsomla:2688) Bug#38261Rafal Somla12 Sep