RE: bzr commit into mysql-6.0-falcon branch (svoj:2805) Bug#33575

[Kevin Lewis]

Sergey, Looks good.  I am glad you are aware of trans_register_ha()  OK to
push.

>-----Original Message-----
>From: Sergey.Vojtovich@stripped [mailto:Sergey.Vojtovich@stripped] On Behalf
>Of Sergey Vojtovich
>Sent: Monday, September 01, 2008 7:00 AM
>To: commits@stripped
>Subject: bzr commit into mysql-6.0-falcon branch (svoj:2805) Bug#33575
>
>#At file:///home/svoj/devel/mysql/BUG33575/mysql-6.0-falcon-team/
>
> 2805 Sergey Vojtovich	2008-09-01
>      BUG#33575 - Backup: crash on shutdown if Falcon table
>
>      Shutting down the server immediately after BACKUP of Falcon table
>      may cause assertion failure.
>
>      The problem was that Falcon didn't inform the server that it has
>      started internal transaction. Thus the server didn't commit this
>      transaction, causing assertion failure on shutdown.
>modified:
>  storage/falcon/ha_falcon.cpp
>
>per-file messages:
>  storage/falcon/ha_falcon.cpp
>    Inform the server that we have started transaction, when starting
>    consistent snapshot.
>=== modified file 'storage/falcon/ha_falcon.cpp'
>--- a/storage/falcon/ha_falcon.cpp	2008-08-27 12:55:46 +0000
>+++ b/storage/falcon/ha_falcon.cpp	2008-09-01 11:59:45 +0000
>@@ -1261,6 +1261,8 @@ int StorageInterface::start_consistent_s
> {
> 	DBUG_ENTER("StorageInterface::start_consistent_snapshot");
> 	int ret = storageHandler->startTransaction(thd,
>TRANSACTION_CONSISTENT_READ);
>+ 	if (!ret)
>+		trans_register_ha(thd, true, hton);
> 	DBUG_RETURN(ret);
>
> }
>
>
>--
>MySQL Code Commits Mailing List
>For list archives: http://lists.mysql.com/commits
>To unsubscribe:    http://lists.mysql.com/commits?unsub=1