List:Commits« Previous MessageNext Message »
From:jonas Date:April 21 2006 1:59pm
Subject:bk commit into 5.1 tree (jonas:1.2376)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2376 06/04/21 13:58:55 jonas@stripped +1 -0
  ndb -
    Fix error handling when out of diskspace

  storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp
    1.32 06/04/21 13:58:52 jonas@stripped +9 -4
    Fix error handling when out of diskspace

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/51-work

--- 1.31/storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp	2006-04-21 09:09:30 +02:00
+++ 1.32/storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp	2006-04-21 13:58:52 +02:00
@@ -1382,8 +1382,9 @@
 			regOperPtr.p->userpointer,
 			&regOperPtr.p->m_tuple_location);
     
-    ((Tuple_header*)ptr)->m_operation_ptr_i= regOperPtr.i;
-    ((Tuple_header*)ptr)->m_header_bits= Tuple_header::ALLOC | 
+    base = (Tuple_header*)ptr;
+    base->m_operation_ptr_i= regOperPtr.i;
+    base->m_header_bits= Tuple_header::ALLOC | 
       (varsize ? Tuple_header::CHAINED_ROW : 0);
     regOperPtr.p->m_tuple_location.m_page_no = real_page_id;
   }
@@ -1471,7 +1472,7 @@
 size_change_error:
   jam();
   terrorCode = ZMEM_NOMEM_ERROR;
-  goto disk_prealloc_error;
+  goto exit_error;
   
 undo_buffer_error:
   jam();
@@ -1505,9 +1506,13 @@
     regOperPtr.p->op_struct.in_active_list = false;
     regOperPtr.p->m_tuple_location.setNull();
   }
-disk_prealloc_error:
+exit_error:
   tupkeyErrorLab(signal);
   return -1;
+
+disk_prealloc_error:
+  base->m_header_bits |= Tuple_header::FREED;
+  goto exit_error;
 }
 
 /* ---------------------------------------------------------------- */
Thread
bk commit into 5.1 tree (jonas:1.2376)jonas21 Apr