List:Commits« Previous MessageNext Message »
From:Vladislav Vaintroub Date:August 29 2008 5:40pm
Subject:bzr push into mysql-6.0-falcon branch (vvaintroub:2805 to 2806)
View as plain text  
 2806 Vladislav Vaintroub	2008-08-29
      Fix build error - generic-msvc.h does not compile in C++.
      The error occurs only when using Visual Studio 2005 
      together with Windows SDK 6.0 and 6.1. The cause of the 
      error is the  conflicting definition for some atomic 
      intrinsics in winnt.h and  intrin.h, as reported on
      https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=262047
      
      The fix is not to include <intrin.h> for VS2005
      but declare intinsics the same way as we do for 
      VS2003.
modified:
  include/atomic/generic-msvc.h

 2805 John H. Embretsen	2008-08-28
      Removing disabled tests (in falcon_team suite) which depend 
      on bugs that are not going to be fixed before 6.0 GA, as 
      agreed upon in Falcon team meeting in Burlington, July 2008.
      
        falcon_bug_22166 (case-sensitive identifiers)
        falcon_bug_22187 (foreign key)
        falcon_bug_28006 (see issue 15491 - ALTER TABLE violates REPEATABLE READ)
      
      The number of disabled tests is being tracked, and we don't
      really want any "permanently" disabled falcon tests.
      
      The test cases and corresponding result files have been 
      attached to their respective bug reports, so that the
      tests can be resurrected once the bugs are fixed (if ever).
removed:
  mysql-test/suite/falcon_team/r/falcon_bug_22166.result
  mysql-test/suite/falcon_team/r/falcon_bug_22187.result
  mysql-test/suite/falcon_team/r/falcon_bug_28006.result
  mysql-test/suite/falcon_team/t/falcon_bug_22166.test
  mysql-test/suite/falcon_team/t/falcon_bug_22187.test
  mysql-test/suite/falcon_team/t/falcon_bug_28006.test
modified:
  mysql-test/suite/falcon_team/t/disabled.def

=== modified file 'include/atomic/generic-msvc.h'
--- a/include/atomic/generic-msvc.h	2008-07-10 11:37:06 +0000
+++ b/include/atomic/generic-msvc.h	2008-08-29 17:38:04 +0000
@@ -30,7 +30,7 @@
 */
 #ifdef _M_IX86
 
-#if (_MSC_VER >= 1400)
+#if (_MSC_VER >= 1500)
 #include <intrin.h>
 #else
 C_MODE_START

Thread
bzr push into mysql-6.0-falcon branch (vvaintroub:2805 to 2806) Vladislav Vaintroub29 Aug