2805 John H. Embretsen 2008-08-28
Removing disabled tests (in falcon_team suite) which depend
on bugs that are not going to be fixed before 6.0 GA, as
agreed upon in Falcon team meeting in Burlington, July 2008.
falcon_bug_22166 (case-sensitive identifiers)
falcon_bug_22187 (foreign key)
falcon_bug_28006 (see issue 15491 - ALTER TABLE violates REPEATABLE READ)
The number of disabled tests is being tracked, and we don't
really want any "permanently" disabled falcon tests.
The test cases and corresponding result files have been
attached to their respective bug reports, so that the
tests can be resurrected once the bugs are fixed (if ever).
removed:
mysql-test/suite/falcon_team/r/falcon_bug_22166.result
mysql-test/suite/falcon_team/r/falcon_bug_22187.result
mysql-test/suite/falcon_team/r/falcon_bug_28006.result
mysql-test/suite/falcon_team/t/falcon_bug_22166.test
mysql-test/suite/falcon_team/t/falcon_bug_22187.test
mysql-test/suite/falcon_team/t/falcon_bug_28006.test
modified:
mysql-test/suite/falcon_team/t/disabled.def
2804 Christopher Powers 2008-08-27 [merge]
merge
removed:
mysql-test/r/backup_view_on_view.result
mysql-test/t/backup_view_on_view.test
added:
mysql-test/include/mysqlbinlog_row_engine.inc
mysql-test/r/backup_backupdir.result
mysql-test/r/backup_concurrent.result
mysql-test/r/mysqlbinlog_row.result
mysql-test/r/mysqlbinlog_row_big.result
mysql-test/r/mysqlbinlog_row_innodb.result
mysql-test/r/mysqlbinlog_row_myisam.result
mysql-test/r/mysqlbinlog_row_trans.result
mysql-test/suite/backup/combinations
mysql-test/suite/backup/include/
mysql-test/suite/backup/include/backup_engine.inc
mysql-test/suite/backup/r/backup_functions.result
mysql-test/suite/backup/r/backup_procedures.result
mysql-test/suite/backup/r/backup_triggers.result
mysql-test/suite/backup/t/backup_functions.test
mysql-test/suite/backup/t/backup_procedures.test
mysql-test/suite/backup/t/backup_triggers.test
mysql-test/t/backup_backupdir.test
mysql-test/t/backup_concurrent.test
mysql-test/t/mysqlbinlog_row.test
mysql-test/t/mysqlbinlog_row_big.test
mysql-test/t/mysqlbinlog_row_innodb.test
mysql-test/t/mysqlbinlog_row_myisam.test
mysql-test/t/mysqlbinlog_row_trans.test
modified:
.bzrignore
client/Makefile.am
client/mysqlbinlog.cc
include/my_global.h
libmysql/CMakeLists.txt
mysql-test/lib/mtr_cases.pl
mysql-test/lib/mtr_report.pl
mysql-test/mysql-test-run.pl
mysql-test/r/backup_progress.result
mysql-test/r/backup_views.result
mysql-test/r/maria.result
mysql-test/r/maria2.result
mysql-test/suite/funcs_1/r/is_columns_mysql.result
mysql-test/suite/funcs_1/r/is_tables_mysql.result
mysql-test/t/backup_progress.test
mysql-test/t/backup_views.test
mysql-test/t/maria.test
mysql-test/t/maria2.test
mysql-test/valgrind.supp
mysys/my_pread.c
scripts/mysql_system_tables.sql
sql/backup/backup_aux.h
sql/backup/backup_info.cc
sql/backup/backup_kernel.h
sql/backup/data_backup.cc
sql/backup/image_info.cc
sql/backup/image_info.h
sql/backup/kernel.cc
sql/backup/stream.cc
sql/backup/stream.h
sql/backup/stream_v1.c
sql/handler.h
sql/log_event.cc
sql/log_event.h
sql/mdl.cc
sql/mysqld.cc
sql/rpl_tblmap.cc
sql/rpl_tblmap.h
sql/rpl_utility.h
sql/set_var.cc
sql/set_var.h
sql/share/errmsg.txt
sql/si_objects.cc
sql/sql_base.cc
sql/sql_parse.cc
sql/sql_select.cc
sql/sql_table.cc
storage/falcon/CMakeLists.txt
storage/falcon/Transaction.cpp
storage/maria/CMakeLists.txt
storage/maria/ha_maria.cc
storage/maria/ma_blockrec.c
storage/maria/ma_check.c
storage/maria/ma_checkpoint.c
storage/maria/ma_close.c
storage/maria/ma_create.c
storage/maria/ma_dbug.c
storage/maria/ma_delete.c
storage/maria/ma_extra.c
storage/maria/ma_info.c
storage/maria/ma_keycache.c
storage/maria/ma_locking.c
storage/maria/ma_loghandler.c
storage/maria/ma_open.c
storage/maria/ma_pagecache.c
storage/maria/ma_recovery.c
storage/maria/ma_search.c
storage/maria/ma_state.c
storage/maria/ma_state.h
storage/maria/ma_update.c
storage/maria/ma_write.c
storage/maria/maria_def.h
storage/maria/maria_ftdump.c
storage/maria/maria_pack.c
storage/myisam/mi_dynrec.c
storage/myisam/mi_examine_log.c
storage/myisam/mi_locking.c
storage/myisam/mi_open.c
storage/myisam/mi_search.c
storage/myisam/myisam_backup_engine.cc
storage/myisam/myisamdef.h
=== removed file 'mysql-test/suite/falcon_team/r/falcon_bug_22166.result'
=== removed file 'mysql-test/suite/falcon_team/r/falcon_bug_22166.result'
--- a/mysql-test/suite/falcon_team/r/falcon_bug_22166.result 2008-04-20 00:05:17 +0000
+++ b/mysql-test/suite/falcon_team/r/falcon_bug_22166.result 1970-01-01 00:00:00 +0000
@@ -1,11 +0,0 @@
-*** Bug #22166 ***
-SET @@storage_engine = 'Falcon';
-DROP TABLE IF EXISTS t;
-DROP TABLE IF EXISTS T;
-CREATE TABLE t(id int);
-CREATE TABLE T(id int);
-SELECT count(*) FROM t;
-count(*)
-0
-DROP TABLE t;
-DROP TABLE T;
=== removed file 'mysql-test/suite/falcon_team/r/falcon_bug_22187.result'
--- a/mysql-test/suite/falcon_team/r/falcon_bug_22187.result 2008-04-20 00:05:17 +0000
+++ b/mysql-test/suite/falcon_team/r/falcon_bug_22187.result 1970-01-01 00:00:00 +0000
@@ -1,21 +0,0 @@
-SET STORAGE_ENGINE = Falcon;
-*** Bug #22187 ***
-DROP TABLE IF EXISTS child;
-DROP TABLE IF EXISTS parent;
-CREATE TABLE parent (id INT NOT NULL, PRIMARY KEY (id));
-CREATE TABLE child (
-id INT,
-parent_id INT,
-INDEX par_ind (parent_id),
-FOREIGN KEY (parent_id) REFERENCES parent(id) ON DELETE CASCADE
-);
-SHOW CREATE TABLE child;
-Table Create Table
-child CREATE TABLE `child` (
- `id` int(11) DEFAULT NULL,
- `parent_id` int(11) DEFAULT NULL,
- KEY `par_ind` (`parent_id`),
- CONSTRAINT `child_ibfk_1` FOREIGN KEY (`parent_id`) REFERENCES `parent` (`id`) ON DELETE CASCADE
-) ENGINE=Falcon DEFAULT CHARSET=latin1
-DROP TABLE child;
-DROP TABLE parent;
=== removed file 'mysql-test/suite/falcon_team/r/falcon_bug_28006.result'
--- a/mysql-test/suite/falcon_team/r/falcon_bug_28006.result 2008-04-20 00:05:17 +0000
+++ b/mysql-test/suite/falcon_team/r/falcon_bug_28006.result 1970-01-01 00:00:00 +0000
@@ -1,33 +0,0 @@
-*** Bug #28006 ***
-SET @@storage_engine = 'Falcon';
-DROP TABLE IF EXISTS t1;
-SET @@tx_isolation = 'REPEATABLE-READ';
-SET @@autocommit = 0;
-CREATE TABLE t1 (a int);
-INSERT INTO t1 VALUES (1);
-COMMIT;
-# Establish connection conn1
-SET storage_engine = 'Falcon';
-SET @@tx_isolation = 'REPEATABLE-READ';
-SET @@autocommit = 0;
-# Switch to connection default
-BEGIN;
-SELECT * FROM t1;
-a
-1
-# Switch to connection conn1
-ALTER TABLE t1 ADD COLUMN b int;
-ALTER TABLE t1 DROP COLUMN a;
-# Switch to connection default
-SELECT * FROM t1;
-a
-1
-COMMIT;
-SELECT count(*) FROM t1;
-count(*)
-1
-COMMIT;
-# Switch to connection conn1
-COMMIT;
-# Switch to connection default
-DROP TABLE t1;
=== modified file 'mysql-test/suite/falcon_team/t/disabled.def'
--- a/mysql-test/suite/falcon_team/t/disabled.def 2008-04-28 21:07:04 +0000
+++ b/mysql-test/suite/falcon_team/t/disabled.def 2008-08-28 08:37:20 +0000
@@ -13,11 +13,8 @@
# If a test has side effects, then it can be disabled for local testing purposes.
#
# Attention: Never ever push disabled tests. This is for local purposes only.
-# Only exception is for tests, which are considered as "won't fix" for long time.
+# Only exception is for tests which are considered as "won't fix" for long time,
+# which should probably be attached to a bug report instead.
# Also please keep the list sorted.
-falcon_bug_22166 : Bug#22166 tests for case-sensitive identifiers.Will probably never be fixed (besides , can never run on case-insensitive filesystems) 2008-04-21 vvaintroub
-falcon_bug_22187 : Bug#22187 Tests for foreign key.Useless without FK implementation 2008-04-21 vvaintroub
-falcon_bug_28006 : Bug#28006 Not a Falcon-specific bug, innodb shows the same behaviour(see Bug#15491) to be fixed in Server. 2008-04-28 vvaintroub
-
=== removed file 'mysql-test/suite/falcon_team/t/falcon_bug_22166.test'
--- a/mysql-test/suite/falcon_team/t/falcon_bug_22166.test 2008-04-20 00:05:17 +0000
+++ b/mysql-test/suite/falcon_team/t/falcon_bug_22166.test 1970-01-01 00:00:00 +0000
@@ -1,33 +0,0 @@
---source include/have_falcon.inc
-#
-# Bug #22166: Case insensitive table names
-#
---echo *** Bug #22166 ***
-
-# ----------------------------------------------------- #
-# --- Initialisation --- #
-# ----------------------------------------------------- #
-let $engine = 'Falcon';
-eval SET @@storage_engine = $engine;
-
---disable_warnings
-DROP TABLE IF EXISTS t;
-DROP TABLE IF EXISTS T;
---enable_warnings
-
-# ----------------------------------------------------- #
-# --- Test --- #
-# ----------------------------------------------------- #
-CREATE TABLE t(id int);
-CREATE TABLE T(id int);
-
-# ----------------------------------------------------- #
-# --- Check --- #
-# ----------------------------------------------------- #
-SELECT count(*) FROM t;
-
-# ----------------------------------------------------- #
-# --- Final cleanup --- #
-# ----------------------------------------------------- #
-DROP TABLE t;
-DROP TABLE T;
=== removed file 'mysql-test/suite/falcon_team/t/falcon_bug_22187.test'
--- a/mysql-test/suite/falcon_team/t/falcon_bug_22187.test 2008-04-20 00:05:17 +0000
+++ b/mysql-test/suite/falcon_team/t/falcon_bug_22187.test 1970-01-01 00:00:00 +0000
@@ -1,25 +0,0 @@
---source include/have_falcon.inc
-SET STORAGE_ENGINE = Falcon;
-#
-# Bug #22187: Can't create FOREIGN KEY
-#
---echo *** Bug #22187 ***
---disable_warnings
-DROP TABLE IF EXISTS child;
-DROP TABLE IF EXISTS parent;
---enable_warnings
-
-
-CREATE TABLE parent (id INT NOT NULL, PRIMARY KEY (id));
-CREATE TABLE child (
- id INT,
- parent_id INT,
- INDEX par_ind (parent_id),
- FOREIGN KEY (parent_id) REFERENCES parent(id) ON DELETE CASCADE
-);
-
-SHOW CREATE TABLE child;
-
-# Final cleanup
-DROP TABLE child;
-DROP TABLE parent;
=== removed file 'mysql-test/suite/falcon_team/t/falcon_bug_28006.test'
--- a/mysql-test/suite/falcon_team/t/falcon_bug_28006.test 2008-04-20 00:05:17 +0000
+++ b/mysql-test/suite/falcon_team/t/falcon_bug_28006.test 1970-01-01 00:00:00 +0000
@@ -1,63 +0,0 @@
---source include/have_falcon.inc
-#
-# Bug #28006: Falcon: isolation failed after alter
-# Note: related to Bug#15491 "ALTER TABLE violates REPEATABLE READ"
-#
---echo *** Bug #28006 ***
-
-# ----------------------------------------------------- #
-# --- Initialisation --- #
-# ----------------------------------------------------- #
-let $engine = 'Falcon';
-eval SET @@storage_engine = $engine;
-
---disable_warnings
-DROP TABLE IF EXISTS t1;
---enable_warnings
-
-SET @@tx_isolation = 'REPEATABLE-READ';
-SET @@autocommit = 0;
-CREATE TABLE t1 (a int);
-INSERT INTO t1 VALUES (1);
-COMMIT;
-
---echo # Establish connection conn1
-connect (conn1,localhost,root,,);
-eval SET storage_engine = $engine;
-SET @@tx_isolation = 'REPEATABLE-READ';
-SET @@autocommit = 0;
-
-# ----------------------------------------------------- #
-# --- Test --- #
-# ----------------------------------------------------- #
---echo # Switch to connection default
-connection default;
-BEGIN;
-SELECT * FROM t1;
-
---echo # Switch to connection conn1
-connection conn1;
-ALTER TABLE t1 ADD COLUMN b int;
-ALTER TABLE t1 DROP COLUMN a;
-
---echo # Switch to connection default
-connection default;
-SELECT * FROM t1;
-COMMIT;
-
-# ----------------------------------------------------- #
-# --- Check --- #
-# ----------------------------------------------------- #
-SELECT count(*) FROM t1;
-COMMIT;
-
-# ----------------------------------------------------- #
-# --- Final cleanup --- #
-# ----------------------------------------------------- #
---echo # Switch to connection conn1
-connection conn1;
-COMMIT;
---echo # Switch to connection default
-connection default;
-disconnect conn1;
-DROP TABLE t1;
| Thread |
|---|
| • bzr push into mysql-6.0-falcon branch (john.embretsen:2804 to 2805) | John H. Embretsen | 29 Aug |
