bzr push into mysql-5.1 branch (msvensson:2662 to 2664) Bug#33337

[Magnus Svensson]

 2664 Magnus Svensson	2008-08-29
      Bug#33337, silently convert --gdb(etc.) to --client-gdb in embedded mode
modified:
  mysql-test/mysql-test-run.pl

 2663 Magnus Svensson	2008-08-29
      Print error message in diff_files if any of the two files to diff does not exist
modified:
  client/mysqltest.cc
  mysql-test/mysql-test-run.pl

 2662 Mats Kindahl	2008-08-27 [merge]
      Automerging
modified:
  mysql-test/include/mtr_warnings.sql
  mysql-test/suite/rpl/r/rpl_temporary_errors.result
  mysql-test/suite/rpl/t/rpl_temporary_errors.test

=== modified file 'client/mysqltest.cc'
--- a/client/mysqltest.cc	2008-08-09 12:59:57 +0000
+++ b/client/mysqltest.cc	2008-08-29 10:25:19 +0000
@@ -3335,6 +3335,14 @@ void do_diff_files(struct st_command *co
                      sizeof(diff_file_args)/sizeof(struct command_arg),
                      ' ');
 
+  if (access(ds_filename.str, F_OK) != 0)
+    die("command \"diff_files\" failed, file '%s' does not exist",
+        ds_filename.str);
+
+  if (access(ds_filename2.str, F_OK) != 0)
+    die("command \"diff_files\" failed, file '%s' does not exist",
+        ds_filename2.str);
+
   if ((error= compare_files(ds_filename.str, ds_filename2.str)))
   {
     /* Compare of the two files failed, append them to output

=== modified file 'mysql-test/mysql-test-run.pl'
--- a/mysql-test/mysql-test-run.pl	2008-08-11 08:41:12 +0000
+++ b/mysql-test/mysql-test-run.pl	2008-08-29 10:33:02 +0000
@@ -1048,6 +1048,28 @@ sub command_line_setup {
       mtr_error("Can't use --extern with --embedded-server");
     }
 
+
+    if ($opt_gdb)
+    {
+      mtr_warning("Silently converting --gdb to --client-gdb in embedded mode");
+      $opt_client_gdb= $opt_gdb;
+      $opt_gdb= undef;
+    }
+
+    if ($opt_ddd)
+    {
+      mtr_warning("Silently converting --ddd to --client-ddd in embedded mode");
+      $opt_client_ddd= $opt_ddd;
+      $opt_ddd= undef;
+    }
+
+    if ($opt_debugger)
+    {
+      mtr_warning("Silently converting --debugger to --client-debugger in embedded
mode");
+      $opt_client_debugger= $opt_debugger;
+      $opt_debugger= undef;
+    }
+
     if ( $opt_gdb || $opt_ddd || $opt_manual_gdb || $opt_manual_ddd ||
 	 $opt_manual_debug || $opt_debugger )
     {
@@ -3486,12 +3508,21 @@ sub report_failure_and_restart ($) {
   if ( !defined $tinfo->{logfile} )
   {
     my $logfile= $path_current_testlog;
-    if ( defined $logfile and -f $logfile )
+    if ( defined $logfile )
     {
-      # Test failure was detected by test tool and its report
-      # about what failed has been saved to file. Save the report
-      # in tinfo
-      $tinfo->{logfile}= mtr_fromfile($logfile);
+      if ( -f $logfile )
+      {
+	# Test failure was detected by test tool and its report
+	# about what failed has been saved to file. Save the report
+	# in tinfo
+	$tinfo->{logfile}= mtr_fromfile($logfile);
+      }
+      else
+      {
+	# The test tool report didn't exist, display an
+	# error message
+	$tinfo->{logfile}= "Could not open test tool report '$logfile'";
+      }
     }
   }