List:Commits« Previous MessageNext Message »
From:Øystein Grøvlen Date:August 27 2008 2:44pm
Subject:Re: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296
View as plain text  
STATUS
------
Test failure on Solaris needs to be fixed.

REQUESTS
--------

1. When I run this test on Solaris, the backup_logs_output tests fails
    because grep option is not portable:

CURRENT_TEST: main.backup_logs_output
grep: illegal option -- q
Usage: grep -hblcnsviw pattern file . . .
mysqltest: At line 184: command "grep -q "BACKUP DATABASE bup_log TO 
'bup_log.bak'" $MYSQLTEST_VARDIR/master-data/backup_history.log" failed 
with wrong error: 2


COMMENTARY
----------
Test changes looks fine.

Wrt bug#33364 that is mentioned in the test: I am not sure the
original proposal fits with your current interpretation.  You are
talking about purging of backup logs, but it seems to me that the
originator also were requesting the ability to purge old backup
images.


SUGGESTIONS
-----------

No other suggestions.

-- 
Øystein
Thread
bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Chuck Bell21 Aug
  • Re: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Øystein Grøvlen27 Aug
    • RE: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Chuck Bell27 Aug
      • RE: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Vladislav Vaintroub27 Aug
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Øystein Grøvlen28 Aug
        • RE: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Chuck Bell28 Aug
    • RE: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Chuck Bell27 Aug
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Øystein Grøvlen28 Aug
    • RE: bzr commit into mysql-6.0-backup branch (cbell:2681) WL#4296Chuck Bell27 Aug