From: Date: August 26 2008 5:34pm
Subject: bzr commit into mysql-5.1 tree (frazer:2666) Bug#38580
List-Archive: http://lists.mysql.com/commits/52578
X-Bug: 38580
Message-Id: <200808261534.m7QFYGYt023395@forth.ndb.mysql.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1656243135=="

--===============1656243135==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

#At file:///home/frazer/bzr/mysql-5.1-telco-6.2-bugs/

------------------------------------------------------------
revno: 2666
revision-id: frazer@stripped
parent: jonas@stripped
committer: Frazer Clement <frazer@stripped>
branch nick: mysql-5.1-telco-6.2-bugs
timestamp: Tue 2008-08-26 16:33:54 +0100
message:
  Bug# 38580 : NDB : Buffer overrun during node shutdown handling results in SEGV
  
  Rather than concatenating to possible max-length string, directly write
  the last bytes.
modified:
  storage/ndb/src/kernel/error/ErrorReporter.cpp sp1f-errorreporter.cpp-20040414082422-tfixuyttj3344ygggk5pfdr7d2w2w3rq

--===============1656243135==
MIME-Version: 1.0
Content-Type: text/text/x-diff; charset="us-ascii"; name="patch-2666.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

=== modified file 'storage/ndb/src/kernel/error/ErrorReporter.cpp'
--- a/storage/ndb/src/kernel/error/ErrorReporter.cpp	2008-04-22 19:36:05 +0000
+++ b/storage/ndb/src/kernel/error/ErrorReporter.cpp	2008-08-26 15:33:54 +0000
@@ -149,7 +149,8 @@
     strcat(messptr, " ");
   }
   
-  strcat(messptr, "\n");
+  messptr[MESSAGE_LENGTH -2]='\n';
+  messptr[MESSAGE_LENGTH -1]=0;
   
   return;
 }


--===============1656243135==--