Re: WL#4380 ABI check: Where and when to run it ?

[Sergei Golubchik]

Hi!

On Aug 26, Joerg Bruehe wrote:
>
> So you think we should try to run it on every platform, provided we can 
> make the compiler generate the check file ?

Yes.

> You have a point.
> I had simply hoped our header files (for the API/ABI) are not so full
> of confitional compiling, so fewer platforms would suffice.

I do hope too :)
But verifying it with an automated check is safer than hoping.

> I would like to know the build times (compile + link, no tests) both with 
> and without the ABI check.

It's for VN to answer

>> Right, but VN has this WL pushed in the team tree, and it's tested on
>> all pushbuild platforms already. As far as I remember this includes
>> Solaris and OS X with gcc.
>
> It is in the team tree before having two reviews ?  No comment.

I did the review, and approved for pushing.

> The stronger you argue to "run it on as many platforms as possible",
> the more important it gets to make the "diff" binary configurable.
> Currently, "diff" output for the same file difference in the test suite 
> differs by platform. (A weird sentence, but you get the meaning.)

Okay. In that case we will need different output (.pp) files
for different platforms, as it's practically impossible to have
different compilers to generate the same cpp output.

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring