OK, good. OK to push. But not for the clone-off. Let's save this for
6.0.8. If you want to keep falcon-team mergeable with mysql-6.0-falcon so
it can go into the clone-off, you may push to falcon-kevin
>-----Original Message-----
>From: Vladislav Vaintroub [mailto:vaintroub@stripped]
>Sent: Monday, August 25, 2008 3:40 PM
>To: 'Kevin Lewis'; 'Vladislav Vaintroub'; commits@stripped
>Subject: RE: bzr commit into mysql-6.0-falcon branch (vvaintroub:2798)
>Bug#38933
>
>
>
>> -----Original Message-----
>> From: Kevin Lewis [mailto:klewis@stripped]
>> Sent: Monday, August 25, 2008 10:36 PM
>> To: 'Vladislav Vaintroub'; commits@stripped
>> Subject: RE: bzr commit into mysql-6.0-falcon branch (vvaintroub:2798)
>> Bug#38933
>>
>> Vlad,
>>
>> It looks like Transaction::dropTable still locks syncIndexes outside
>> releaseDeferredIndexes().
>
>Actually it does not
>
>void Transaction::dropTable(Table* table)
> {
>- Sync sync(&syncIndexes, "Transaction::dropTable");
>- sync.lock(Exclusive);
>-
> releaseDeferredIndexes(table);
>
>- // Keep exclusive lock to avoid race condition with writeComplete
>-
>+ Sync syncRec(&syncRecords,"Transaction::dropTable(2)");
>+ syncRec.lock(Exclusive);
> for (RecordVersion **ptr = &firstRecord, *rec; (rec = *ptr);)
> if (rec->format->table == table)
> removeRecord(rec);
