List:Commits« Previous MessageNext Message »
From:Jørgen Løland Date:August 21 2008 4:30pm
Subject:Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679)
Bug#34171
View as plain text  
Sergei Golubchik wrote:

> No, you should never set secure-file-priv in the test suite to point
> outside of VARDIR. Read why it was introduced to fix the bug#18628.  By
> setting it to / you make the latter bug to reappear.

Thanks for looking at the patch Sergei.

I'll create a follow-up patch later that removes the secure-file-priv=/ 
option and modifies a few test cases in backup_backupdir.test that will 
fail when I do this.

Reviewers should still be able to review the current patch.

-- 
Jørgen Løland
Thread
bzr commit into mysql-6.0-backup branch (jorgen.loland:2679) Bug#34171Jorgen Loland21 Aug
  • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679)Bug#34171Sergei Golubchik21 Aug
    • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679)Bug#34171Jørgen Løland21 Aug
  • RE: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679) Bug#34171Chuck Bell21 Aug
  • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679) Bug#34171Alexander Nozdrin21 Aug