List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:August 21 2008 9:25am
Subject:Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679)
Bug#34171
View as plain text  
Hi!

On Aug 21, Jorgen Loland wrote:
> #At file:///localhome/jl208045/mysql/mysql-6.0-backup-34171/
> 
>  2679 Jorgen Loland	2008-08-21
>       Bug#34171 - "Backup: ignoring --secure-file-priv"
>       
>       Before patch: Backup code ignored secure-file-priv option, 
>       allowing backup to write to any location
>       
> === added file 'mysql-test/t/backup_backupdir-master.opt'
> --- a/mysql-test/t/backup_backupdir-master.opt	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/t/backup_backupdir-master.opt	2008-08-21 08:38:12 +0000
> @@ -0,0 +1 @@
> +--secure-file-priv=/

No, you should never set secure-file-priv in the test suite to point
outside of VARDIR. Read why it was introduced to fix the bug#18628.  By
setting it to / you make the latter bug to reappear.
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
bzr commit into mysql-6.0-backup branch (jorgen.loland:2679) Bug#34171Jorgen Loland21 Aug
  • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679)Bug#34171Sergei Golubchik21 Aug
    • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679)Bug#34171Jørgen Løland21 Aug
  • RE: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679) Bug#34171Chuck Bell21 Aug
  • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2679) Bug#34171Alexander Nozdrin21 Aug