List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:August 20 2008 11:16pm
Subject:Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492
View as plain text  
* Konstantin Osipov <konstantin@stripped> [08/08/21 00:39]:
> > When thread is closing MySQL Server unlock tables after "sending OK to
> > client" (actually the flag means that output just closed, as I
> > understand). It is the situation which is not possible in normal query
> > processing and there is no way to detect it.
> 
> Committing an internal maria transaction in external_lock() is a
> maria hack. It has backfired already in having to add
> maria::implicit_commit() in a few places. Now some assert files. 
> The diagnostics area is a brand new class that has been made
> clean. Now it contains a member that tracks information that is
> totally unrelated to the purpose of the class. 
> Again, only because maria engine has a hack in it. 
> Can you please find a better solution (preferably maria-specific)?

Thinking more of it, you could just as successfully add
bool is_quit to class String. 

Then the code in COM_QUIT would set:

thd->convert_buffer.is_quit= TRUE;

And in maria you could check for thd->convert_buffer.is_quit.

I am trying to point out that diagnostics_area is not a
single-instance class -- with the fix for Bug#23032 there will be
multiple diagnostics area instances created during execution, and
is_quit has as little relevance to the purpose of this class as it
has to, say, the purpose of class String.

The best way, perhaps, is to put it, if so much needed, to
thd->ha_data[maria_hton->slot].ha_ptr. 

-- 
Thread
bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492sanja20 Aug
  • Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492Konstantin Osipov20 Aug
    • Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492Sanja Byelkin20 Aug
      • Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492Konstantin Osipov20 Aug
        • Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492Konstantin Osipov21 Aug