List:Commits« Previous MessageNext Message »
From:Sanja Byelkin Date:August 20 2008 7:37pm
Subject:Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492
View as plain text  
Hi!

On Wed, Aug 20, 2008 at 09:01:36PM +0400, Konstantin Osipov wrote:
> * sanja@stripped <sanja@stripped> [08/08/20 19:08]:
> >  2689 sanja@stripped	2008-08-20
> >       Ignore OK "sent" to user if it is connection termination (BUG#38492).
> 
> 
> Why do you have to add a new member? Isn't checking for DISABLED
> sufficient?

It do not show that thread is termninating. At least description says:

/**
  Mark the diagnostics area as 'DISABLED'.

  This is used in rare cases when the COM_ command at hand sends a response
  in a custom format. One example is the query cache, another is
  COM_STMT_PREPARE.
*/

and

    /** Set in case of a custom response, such as one from COM_STMT_PREPARE. */
    DA_DISABLED


> Need for a new member in a class that is very remotely related to
> a storage engine does not seem to be justified by an assert in the
> storage engine. 

When thread is closing MySQL Server unlock tables after "sending OK to
client" (actually the flag means that output just closed, as I
understand). It is the situation which is not possible in normal query
processing and there is no way to detect it.

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /    Mr. Oleksandr Byelkin <sanja@stripped>
 / /|_/ / // /\ \/ /_/ / /__   MySQL AB, Full-Time Developer
/_/  /_/\_, /___/\___\_\___/   Lugansk, Ukraine
       <___/   www.mysql.com
Thread
bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492sanja20 Aug
  • Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492Konstantin Osipov20 Aug
    • Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492Sanja Byelkin20 Aug
      • Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492Konstantin Osipov20 Aug
        • Re: bzr push into mysql-6.0 branch (sanja:2688 to 2689) Bug#38492Konstantin Osipov21 Aug