List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:August 20 2008 4:28pm
Subject:Re: bzr commit into mysql-5.1 branch (gshchepa:2688) Bug#26020
View as plain text  
Hi!

On Aug 20, Gleb Shchepa wrote:
>
>>> +    if (name.length == var->name.length &&
>>>      !memcmp(name.str, var->name.str, name.length))
>> memcmp() is probably wrong, it should be charset-aware
>> comparison.
>
> IMHO the trouble with var->name is even more general:
>
> set names koi8r;
> set @тест = 10; # variable name is in KOI8-R
> set names utf8;
> select @тест;   # variable name is in UTF-8
> # result is NULL
>
> How do you think, is it a bug?

I think yes, but a separate one, not related to yours.
When I wrote about "charset-aware comparison" I was thinking about, for
example,

  select @a, @A:=...

Regards / Mit vielen GrЭssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB MЭnchen 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
GeschДftsfЭhrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin HДring
Thread
bzr commit into mysql-5.1 branch (gshchepa:2688) Bug#26020Gleb Shchepa13 Aug
  • Re: bzr commit into mysql-5.1 branch (gshchepa:2688) Bug#26020Sergei Golubchik19 Aug
    • Re: bzr commit into mysql-5.1 branch (gshchepa:2688) Bug#26020Gleb Shchepa20 Aug
      • Re: bzr commit into mysql-5.1 branch (gshchepa:2688) Bug#26020Sergei Golubchik20 Aug