Re: commit into mysql-5.1 branch (bar:2675) Bug#31455

[Alexander Barkov]

Hi Andrei,

Andrei Elkin wrote:
> Alexander, good day!
> 
> regarding to --short-form
> 
>>> Another point here. There is --short-form, which is under repairment
>>> from   Bug #18337 mysqlbinlog not displaying BINLOG statements when
>>> called with --short-form, whose intended purpose is to remove
>>> `#'-started comments as the docs say. In some sense --short-form is
>>> the negation of -v.
>>>
>>> I wonder how the combination of --short-form and -v should behave,
>>> looks like there are two options of either one is more superior.
> 
>> --short-form disables printing both row events themself,
>> and their decoded SQL queries, which seems to be inline
>> with what the manual says.
> 
> to be precise, Bug#18337 underlines (you can read discussion on the
> bug page) --short-form must print the row events.
> 
>    *  `--short-form', `-s'
> 
>      Display only the statements contained in the log, without any
>      extra information.
> 
> If we follow these lines the new -v should not print anything if
> conbined with --short-form.
> 
> 
>> So everything looks fine here, right?
> 
> Imagining bug#18337 is fixed, we still need to make sure that the
> combination of --short-form and -v indeed does not print any extra.
> 

Will this change work?

< print_event_info.verbose= verbose;

 > print_event_info.verbose= short_form ? 0 : verbose;



> regards,
> 
> 
> Andrei