Re: bzr commit into mysql-5.1 branch (mats:2658) Bug#38773

[He Zhenxing]

Hi,

Patch approved, just a minor comment, see below.

Mats Kindahl wrote:
> #At file:///home/bzr/bugs/b38773-5.1-rpl/
> 

[snip]

> -    
>      error= -1;
> +    tmp_disable_binlog(thd);
>      if ((deleted= mysql_rm_known_files(thd, dirp, db, path, 0,
>                                         &dropped_tables)) >= 0)
>      {
> @@ -927,6 +920,7 @@ bool mysql_rm_db(THD *thd,char *db,bool 
>  #endif
>        error = 0;
>      }
> +    reenable_binlog(thd);
>    }
>    if (!silent && deleted>=0)
>    {
> 

Please add comments to explain why binlog is disabled temporarily.