List:Commits« Previous MessageNext Message »
From:Øystein Grøvlen Date:August 18 2008 2:44pm
Subject:Re: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073
View as plain text  
Øystein Grøvlen wrote:
> Chuck Bell wrote:
>> Oystein,
>>
>> Answering interdelinia... 
> 
> Thanks for answers, the only issues I have, in addition to you checking 
> up the encoding issue, is test comments that still I do not feel are 
> correct (see below).  However, I did not get an answer to why you have 
> added drop user statements to some existing tests.
> 

Also discovered that I had forgotten two questions on 
execute_backup_test_command changes:

  - Why have you commented some code instead of removing it?  Will it be
    needed in the future?

  - You call user_exists without testing the outcome.  Is there any side
    effects?

-- 
Øystein
Thread
bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Chuck Bell7 Aug
  • Re: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Øystein Grøvlen18 Aug
    • RE: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Chuck Bell18 Aug
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Øystein Grøvlen18 Aug
        • Re: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Øystein Grøvlen18 Aug
        • RE: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Chuck Bell18 Aug
          • Re: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Øystein Grøvlen19 Aug
            • RE: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Chuck Bell19 Aug
            • RE: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Chuck Bell19 Aug
RE: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073Chuck Bell18 Aug