RE: bzr commit into mysql-6.0-backup branch (cbell:2676) WL#4073

[Chuck Bell]

Oystein,

> Thanks for answers, the only issues I have, in addition to 
> you checking up the encoding issue, is test comments that 
> still I do not feel are correct (see below).  However, I did 
> not get an answer to why you have added drop user statements 
> to some existing tests.

Ah. Missed that one...

> > === modified file 'mysql-test/t/backup_ddl_blocker.test'
> > --- a/mysql-test/t/backup_ddl_blocker.test	2008-06-25 
> 13:39:04 +0000
> > +++ b/mysql-test/t/backup_ddl_blocker.test	2008-08-07 
> 14:53:39 +0000
> > @@ -146,6 +146,10 @@ send ALTER TABLE bup_ddl_blocker.t2 ADD 
> >  
> >  connection con1;
> >  
> > +#Drop of the user ''@'%' if it exists.
> > +--error 0,ER_CANNOT_USER
> > +DROP USER ''@'%';
> > +
> 
> Why is this added?  Did your code changes make this test fail without
> it?  Or are you trying to test something that was not tested before?
> If the latter, how is it related to your code changes?

Because some tests create the anonymous user and I do not want the anonymous
user included in the backup. I can remove these if you like but it is better
to clean up properly.

I could also add a test case for a backup with the anonymous user if you
think that important enough to consider a special case (I am thinking it
couldn't hurt).

Chuck