Hi!
On Aug 18, Narayanan wrote:
>
> I will change the rule to not run as part of the main build, basically
> remove it from all-am. As long as it detects the changes
> and generates the requisite noise, I am as happy as can be.
...
> As long as it runs as part of pushbuild and someone helps me with doing
> this, I am OK.
But I'm not. I believe it must be run as a part of *every* build (if the
prerequisites are met, of course).
>> As regards .PHONY:
>> A Makefile target should be declared .PHONY if it doesn't correspond to a
>> file, that's what I took from "info make" (node "Phony targets").
>
> If it has to be run as a separate target, it does not need to be included
> as part of .PHONY also.
It still does. Otherwise a file 'abi_check' will prevent this rule from
running.
>> They have something called "diff", but I would not rely on it supporting
>> "-w" (above):
>> 1) Copy the (g)tar rule, so that we can provide a "gdiff" if needed.
>> 2) Put it into the section where you checked for "gcc", there is no need
>> to look for "diff" if we don't run the abi_check on that platform.
>
> Will do!
Is there a practical need to do that ? Any single host where we have gcc
and diff -w doesn't work ?
>> IMO, there are two choices:
>> a) Have "@CC@ -E -nostdinc -dI" hard-coded, like it is now (which means
>> we can only do it on gcc platforms), or
>> b) if it is "gcc", set some variable ("@ABI_CHECK@" ?) to the gcc line,
>> otherwise set it to "no" or some other string.
>> With approach a), it is the user's responsibility not to call "make
>> abi_check" with a compiler that doesn't accept these options,
>> with b), we (or some other user) could expand "configure.in" by adding
>> settings for other compilers.
>>
>> As you can tell, I would prefer b), but I won't reject a).
>
> Will work on b)
Again, any practical need to do that ? Any compiler besides gcc that
supports a functionality identical to "-E -nostdinc -dI" ? Or, at least,
to "-E -nostdinc" ?
Regards / Mit vielen Grüssen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
<___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring
