List:Commits« Previous MessageNext Message »
From:Øystein Grøvlen Date:August 15 2008 9:08am
Subject:Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2681)
Bug#33566, Bug#35117, Bug#36792
View as plain text  
Two things you may consider:

1. Before setting in_use, I wonder whether there should be a test (or
    assert) that it actually points to the locking thread.  Otherwise,
    you will cover up any bugs that the causes the table to be locked
    by other threads.

2. The echo for each test case "Server crash for ..." may lead people
    to think that the server is expected to crash, but it will not
    after this fix.

--
Øystein
Thread
bzr commit into mysql-6.0-backup branch (jorgen.loland:2681) Bug#33566,Bug#35117, Bug#36792Jorgen Loland13 Aug
  • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2681)Bug#33566, Bug#35117, Bug#36792Øystein Grøvlen15 Aug
  • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2681)Bug#33566, Bug#35117, Bug#36792Konstantin Osipov15 Aug
    • Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2681)Bug#33566, Bug#35117, Bug#36792Jørgen Løland18 Aug