From: Date: August 14 2008 4:24am
Subject: bzr commit into mysql-5.1 branch (hezx:2675) Bug#38290
List-Archive: http://lists.mysql.com/commits/51588
X-Bug: 38290
Message-Id: <200808140224.m7E2Ot54008480@mail.hezx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

#At file:///media/sda3/work/mysql/bzrwork/b38290/5.1-rpl-testfixes/

 2675 He Zhenxing	2008-08-14
      BUG#38290 valgrind warnings in binlog_base64_flag
      
      The problem was because the event allocated in mysql_client_binlog_statement
      was not freed when an error occured while applying the event.
modified:
  sql/sql_binlog.cc

per-file messages:
  sql/sql_binlog.cc
    Delete the event if apply it failed
=== modified file 'sql/sql_binlog.cc'
--- a/sql/sql_binlog.cc	2008-02-19 12:45:21 +0000
+++ b/sql/sql_binlog.cc	2008-08-14 02:24:06 +0000
@@ -208,6 +208,7 @@ void mysql_client_binlog_statement(THD* 
 #if !defined(MYSQL_CLIENT) && defined(HAVE_REPLICATION)
       if (apply_event_and_update_pos(ev, thd, thd->rli_fake, FALSE))
       {
+        delete ev;
         /*
           TODO: Maybe a better error message since the BINLOG statement
           now contains several events.