Hi Chuck,
Changes from previous version looks good. In addition to the issues
raised on the previous patch, I have only some minor comments on test
that you could fix if you feel like it:
Chuck Bell wrote:
...
> +# Create data for this test and tailor it to the test.
> +--disable_warnings
> +DROP DATABASE IF EXISTS bup_ddl_blocker;
> +--enable_warnings
> +
> +CREATE DATABASE bup_ddl_blocker;
> +
> +--disable_warnings
> +DROP TABLE IF EXISTS bup_ddl_blocker.t1, bup_ddl_blocker.t2,
> + bup_ddl_blocker.t3, bup_ddl_blocker.t4;
The above statement is strictly not necessary since the database was
just created.
...
> +#
> +# Part C - test default behavior: set backup timeout = default
> +#
> +--echo Part C
> +
> +connection con1;
> +
> +SET backup_wait_timeout = DEFAULT;
> +SHOW VARIABLES LIKE 'backup_wait%';
Here you test the variable after you set it to default. Maybe you could
also test its value without setting it at all?
--
Øystein
