List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:August 12 2008 9:26pm
Subject:RE: bzr commit into mysql-6.0-backup branch (cbell:2676) Bug#33414
View as plain text  
Oystein,

I have another patch for you to review. I had some second thoughts about the
test and setting default values. Upon further investigation, I was missing
this capability. So good catch on your part (unknowingly!). That's what
makes a great team, eh?

I added some comments to try and help explain what the functions are and how
they are used -- parameters et. al. 

I added the code to set the default value.

I changed section "C" of the test to simply test setting the default value.
I removed the portion of the test that exercised the timeout -- it was too
long of a test (min 51 seconds) and values are tested in the other cases. I
hope you agree.

http://lists.mysql.com/commits/51460

Let me know if you have any additional questions.

Chuck 


Thread
bzr commit into mysql-6.0-backup branch (cbell:2676) Bug#33414Chuck Bell8 Aug
  • Re: bzr commit into mysql-6.0-backup branch (cbell:2676) Bug#33414Jørgen Løland8 Aug
  • Re: bzr commit into mysql-6.0-backup branch (cbell:2676) Bug#33414Øystein Grøvlen12 Aug
    • RE: bzr commit into mysql-6.0-backup branch (cbell:2676) Bug#33414Chuck Bell12 Aug
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2676) Bug#33414Peter Gulutzan12 Aug
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2676) Bug#33414Øystein Grøvlen13 Aug
  • RE: bzr commit into mysql-6.0-backup branch (cbell:2676) Bug#33414Chuck Bell12 Aug