Patch looks good except the test fails when Falcon not available.
main.backup_default [ fail ]
--- d:/source/bzr/mysql-6.0-review/mysql-test/r/backup_default.result
2008-08-
12 17:34:51.023986200 +0300
+++ d:\source\bzr\mysql-6.0-review\mysql-test\r\backup_default.reject
2008-08-
12 17:51:08.847186200 +0300
@@ -39,6 +39,9 @@
char_column char(5))
engine=falcon
PARTITION BY HASH (int_column);
+Warnings:
+Warning 1286 Unknown table engine 'falcon'
+Warning 1266 Using storage engine MyISAM for table
'partition_table'
INSERT INTO partition_table VALUES (0,'pVtIa');
INSERT INTO partition_table VALUES (5,'jTfSg');
INSERT INTO partition_table VALUES (20,'UezFi');
> 2681 Jorgen Loland 2008-08-12
> Bug#35117 - Backup: Server crash for backup of CSV
> engine with CHAR data type
> Bug#33566 - Backup: crash with partitions and Falcon
> Bug#36792 - Assertion table->in_use == current_thd in
> Field_string::store, line 6259
>
> Patch applies to all three bugs.
>
> Before: With default driver, the table->in_use variable is set
> to point to the locking thread when a table is locked. The
> variable points to the wrong thread (i.e., the locking
> thread) when backup later tries to get the data from the table.
>
> Now: Before getting data from a table, the default driver sets
> the table->in_use pointer to the backup thread.
...
> === added file 'mysql-test/t/backup_default.test'
> --- a/mysql-test/t/backup_default.test 1970-01-01
> 00:00:00 +0000
> +++ b/mysql-test/t/backup_default.test 2008-08-12
> 13:54:49 +0000
> @@ -0,0 +1,128 @@
> +#############################################################
> ##########
> +#### # Purpose: To test backup using default driver
> +#############################################################
> ##########
> +########
> +--source include/not_embedded.inc
We need to add:
--source include/have_falcon.inc
Patch approved pending this change.
Chuck
