Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2676) Bug#38624

[Øystein Grøvlen]

Fix look good, but I am not sure I like the mechanism used in the second 
test case:

> +  DBUG_EXECUTE_IF("backup_fail_add_trigger", DBUG_RETURN(TRUE););
>    if (open_tables(thd, &lst, &num_tables, 0))
> -    DBUG_RETURN(FALSE);
> +    DBUG_RETURN(TRUE);
>  
>    DBUG_ASSERT(num_tables == 1);
>    Table_triggers_list *triggers= lst->table->triggers;

Any particular reason we should test that the code works if TRUE is 
returned from this particular point in this function, and not from all 
the other places that may return TRUE?  I do not think it makes sense to 
add such "error triggers" for all potential errors in the code, so what 
makes this code exceptional?

-- 
Øystein