Re: bzr commit into mysql-6.0-backup branch (jorgen.loland:2676) Bug#34867

[Øystein Grøvlen]

Jørgen Løland wrote:
> Øystein Grøvlen wrote:
>> Patch looks good. If it were me, I would have changed 
>> bcat_get_item_create_data to return success, instead of commenting the 
>> call, but I will not insist on such a change.
> 
> Øystein,
> 
> Thanks for the review. If I do as suggested, I would still have to 
> comment out the flags-update after returning BSTREAM_OK:
> 
> /*
> ret= bcat_get_item_create_data(cat,item,&data);
> if (ret == BSTREAM_OK)
>   flags |= BSTREAM_FLAG_HAS_EXTRA_DATA;     // <-- here
> else if (ret == BSTREAM_ERROR) +    goto wr_error;
> */
> 
> I don't think that's an improvement vs. the current code. Leaving it as 
> it is since you don't have strong objections.
> 

Hm.  Makes me dislike the bcat_get_item_create_data behavior even more. 
          I suspect that once it is introduced, extra metadata will be 
optional.  In that case the commented code would not work anyway.  Makes 
me wonder whether it is better to just delete the above lines.

-- 
Øystein