From: Date: August 8 2008 11:41am Subject: Re: bzr commit into mysql-6.0-backup branch (oystein.grovlen:2676) Bug#36795 List-Archive: http://lists.mysql.com/commits/51182 Message-Id: <489C14E5.8020509@sun.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Patch good to push. Oystein Grovlen wrote: > #At file:///export/home/tmp/oysteing/mysql/mysql-6.0-backup/ > > 2676 Oystein Grovlen 2008-08-06 > Bug#36795 Concurrency issues when starting backups in parallel. > > Raise condition on Backup_restore_ctx::mem_alloc since it is static. > The failing backup will set mem_alloc to null when terminating. The > next time the running backup wants to allocate memory, an assert will > fail. > > Makes mem_alloc non-static. That way, concurrent backups will not > interfere. This requires that it is possible to bstream_alloc to find > the right Backup_restore_ctx to use. Fixes that by changing the > static is_running flag to a static pointer, current_op, to the Backup_restore_ctx > of the currently running backup. If the pointer is null, it means > that no backup is currently running. -- Jørgen Løland