Re: bzr commit into mysql-6.0-backup branch (cbell:2674) WL#4073

[Jørgen Løland]

Chuck,

That was a significant amount of code, and I only have minor comments:

1. The patch fail on the current tree, but I managed to append it 
(partially manually)

2. backup_views fails, probably because you missed a push to the tree

3. Is DBUG_PRINT in Db/Col-GrantIterator::create_obj supposed to be 
"TblGrantIterator::next"?

4. In is_objects.cc#split_user_host, can't the "tics++;" lines be moved 
into the body of the ifs with "cptr++;len--;" is performed? I don't see 
any added value by the extra strncmp checks.

5. Documentation for *get_name in si_objects.h - are you certain it 
should return the *user name*?

Approved with required fix for 1 and 2. 3-5 should be considered but 
only fixed if you agree.


Chuck Bell wrote:
> #At file:///C:/source/bzr/mysql-6.0-wl-4073/
> 
>  2674 Chuck Bell	2008-08-06
>       WL#4073 : Online Backup: backup and restore database object permissions
>       
>       This patch adds the ability to backup privileges (grants) for databases.
> added:
>   mysql-test/r/backup_db_grants.result
>   mysql-test/t/backup_db_grants.test
> modified:
>   mysql-test/lib/mtr_report.pl
>   mysql-test/r/backup_ddl_blocker.result
>   mysql-test/r/backup_no_data.result
>   mysql-test/t/backup_ddl_blocker.test
>   mysql-test/t/backup_no_data.test
>   sql/backup/backup_aux.h
>   sql/backup/backup_info.cc
>   sql/backup/backup_info.h
>   sql/backup/backup_test.cc
>   sql/backup/image_info.cc
>   sql/backup/image_info.h
>   sql/backup/kernel.cc
>   sql/share/errmsg.txt
>   sql/si_objects.cc
>   sql/si_objects.h


-- 
Jørgen Løland