Re: bzr commit into mysql-5.1 branch (holyfoot:2680) Bug#38272

[Sergei Golubchik]

Hi!

On Jul 27, Alexey Botchkov wrote:
>  2680 Alexey Botchkov	2008-07-27
>       Bug#38272 timestamps fields incorrectly defaulted on update accross
> partitions.
>       
>       It's not Innodb-specific bug.
>       ha_partition::update_row() didn't set
>       table->timestamp_field_type= TIMESTAMP_NO_AUTO_SET when
>       orig_timestamp_type == TIMESTAMP_AUTO_SET_ON_INSERT.
>       
>       So that a partition sets the timestamp field when a record
>       is moved to a different partition.
>       
>       Fixed by doing '= TIMESTAMP_NO_AUTO_SET' unconditionally.
>       Also ha_partition::write_row() is fixed in same way as now
>       Field_timestamp::set() is called twice in SET_ON_INSERT case.

ok to push
       
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring