Re: bzr commit into mysql-5.1-telco-6.2 branch (monty:2633) Bug#38177

[Jonas Oreland]

Monty Taylor wrote:
> Jonas Oreland wrote:
>> summary: - some questions on ndb inline below
>>          - the fact that you modify my_global.h still makes me believe that you
> do something wrong
> 
> Well... you are right, I thougt my_global.h was getting included from
> somewhere, but now I'm not seeing the problem anymore... so I'll remove
> those from the patch.
> 
>> my_global.h/mysql_com.h:
>> 1) neither of these are public headers
> 
> They are installed. They are included by mysql.h. They are public.
> 
> I agree though... they _should_not_ be public. But that's a much larger
> cleanup that is not for us. :)
> 
>> 2) you told me you (illegally) use these for decimal etc conversion, right?
>> 3) but that does not (in my book) imply that they should be exposed in "Public
> headers"
>>    i.e you can (if someone looks the other way) use them in your .c-files.
>>        but using them in .h-files sounds *insane*
>> 4) it could also be that your unspecified test-program include them directly.
>>    in that case, you'll have to try to get a "sql-server" guy to review them
> instead
>>    and commit it in separate patch.
> 
> I'll go find a MySQL server fellow and send in that part to him directly.

good that we agree.

> Yes. They are defined twice.

ok, so that ndb part is ok to push
thx for the effort

/Jonas