Re: bzr commit into mysql-5.1 branch (msvensson:2640) Bug#33337

[Sergei Golubchik]

Hi!

On Aug 01, Magnus Svensson wrote:
> #At file:///data/msvensson/mysql/5.1-rpl/
> 
>  2640 Magnus Svensson	2008-08-01
>       Bug #33337  mysql-test-run.pl options --gdb and --ddd don't work with
> --embedded-server
> modified:
>   mysql-test/mysql-test-run.pl

Could you, instead of an error, make --gdb to work ?
It's basically just implying --client-gdb if --gdb is specific in
--embedded-server mode. Something like

  if ($opt_gdb)
    $opt_client_gdb=1;

Options that don't work at all in embedded server mode, could continue
to return an error.
 
> === modified file 'mysql-test/mysql-test-run.pl'
> --- a/mysql-test/mysql-test-run.pl	2008-07-24 20:58:18 +0000
> +++ b/mysql-test/mysql-test-run.pl	2008-08-01 14:13:35 +0000
> @@ -1044,6 +1044,13 @@ sub command_line_setup {
>      {
>        mtr_error("Can't use --extern with --embedded-server");
>      }
> +
> +    if ( $opt_gdb || $opt_ddd || $opt_manual_gdb || $opt_manual_ddd ||
> +	 $opt_manual_debug || $opt_debugger )
> +    {
> +      mtr_error("You need to use the client debug options for the",
> +		"embedded server. Ex: --client-gdb");
> +    }
>    }
>  
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring