List:Commits« Previous MessageNext Message »
From:He Zhenxing Date:July 31 2008 3:20am
Subject:Re: bzr commit into mysql-5.1 branch (hezx:2632) Bug#37051
View as plain text  
Hi Ingo

Thank you!

Ingo Strüwing wrote:
> Hi Zhenxing,
> 
> approved by me, but please extend the comment I mentioned previously.
> Please see below.
> 
> He Zhenxing, 30.07.2008 16:34:
> > #At file:///media/sda3/work/mysql/bzrwork/b37051/5.1-rpl-new/
> > 
> >  2632 He Zhenxing	2008-07-30
> >       BUG#37051 Replication rules not evaluated correctly
> ...
> > === modified file 'sql/log_event.cc'
> ...
> > -  uchar buf[QUERY_HEADER_LEN+
> > -            1+4+           // code of flags2 and flags2
> > -            1+8+           // code of sql_mode and sql_mode
> > -            1+1+FN_REFLEN+ // code of catalog and catalog length and catalog
> > -            1+4+           // code of autoinc and the 2 autoinc variables
> > -            1+6+           // code of charset and charset
> > -            1+1+MAX_TIME_ZONE_NAME_LENGTH+ // code of tz and tz length and tz
> name
> > -            1+2+           // code of lc_time_names and lc_time_names_number
> > -            1+2            // code of charset_database and
> charset_database_number
> > -            ], *start, *start_of_status;
> > +  uchar buf[QUERY_HEADER_LEN + MAX_SIZE_LOG_EVENT_STATUS];
> ...
> >    /*
> >      Here there could be code like
> >      if (command-line-option-which-says-"log_this_variable" && inited)
> 
> Please extend this comment so that it asks for extension of
> MAX_SIZE_LOG_EVENT_STATUS when new options are added.
> 

Good

> ...
> 
> Regards
> Ingo

Thread
bzr commit into mysql-5.1 branch (hezx:2632) Bug#37051He Zhenxing30 Jul
  • Re: bzr commit into mysql-5.1 branch (hezx:2632) Bug#37051Sven Sandberg30 Jul
    • Re: bzr commit into mysql-5.1 branch (hezx:2632) Bug#37051He Zhenxing31 Jul
  • Re: bzr commit into mysql-5.1 branch (hezx:2632) Bug#37051Ingo Strüwing30 Jul
    • Re: bzr commit into mysql-5.1 branch (hezx:2632) Bug#37051He Zhenxing31 Jul