From: Date: July 29 2008 12:19am
Subject: RE: bzr commit into mysql-6.0-backup branch (ingo.struewing:2672) Bug#38133
List-Archive: http://lists.mysql.com/commits/50613
Message-Id: <330E557060EB4B468E5372596D544273@mysqlcabdesk>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit

Ingo,

Ok to push.

Chuck 

>  2672 Ingo Struewing	2008-07-23
>       Bug#38133 - Myisamlog test fails on Windows
>       
>       Updating of a table from the myisam.log file was not 
> possible in most cases.
>       - The initialization of myisamlog set the number of 
> usable file descriptors
>       to one (1!) on Windows.
>       - Every log command to a different file required a 
> close of the previous file.
>       After a 'close' command the closing of the previous 
> file failed due to a
>       lack of closable files and myisamlog stopped.
>       - File locking on Windows failed for the sequence 
> "exclusive lock, shared lock,
>       unlock, exclusive lock". It blocked on the last try to 
> acquire an exclusive lock.
>       
>       Fixed by
>       - requesting a reasonable number of file descriptors,
>       - before re-open, close a file only if all file 
> descriptors are in use,
>       - do not re-open a file, if the command is 'close',
>       - unlock a file before every lock.
> modified:
>   mysql-test/r/myisamlog.result
>   mysql-test/t/myisamlog.test
>   mysys/my_file.c
>   mysys/my_lock.c
>   storage/myisam/mi_close.c
>   storage/myisam/mi_examine_log.c
>   storage/myisam/mi_locking.c
>   storage/myisam/myisamlog.c