From: Date: April 18 2006 9:47am Subject: bk commit into 5.0 tree (serg:1.2164) BUG#16855 List-Archive: http://lists.mysql.com/commits/5050 X-Bug: 16855 Message-Id: <20060418074730.24287.qmail@serg.mylan> Below is the list of changes that have just been committed into a local 5.0 repository of serg. When serg does a push these changes will be propagated to the main repository and, within 24 hours after the push, to the public repository. For information on how to access the public repository see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html ChangeSet 1.2164 06/04/18 09:46:57 serg@stripped +1 -0 revert bug#16855 "fix" per Monty's request client/mysql.cc 1.201 06/04/18 09:46:33 serg@stripped +2 -9 revert bug#16855 "fix" per Monty's request # This is a BitKeeper patch. What follows are the unified diffs for the # set of deltas contained in the patch. The rest of the patch, the part # that BitKeeper cares about, is below these diffs. # User: serg # Host: serg.mylan # Root: /usr/home/serg/Abk/mysql-5.0 --- 1.200/client/mysql.cc Sun Apr 16 23:17:33 2006 +++ 1.201/client/mysql.cc Tue Apr 18 09:46:33 2006 @@ -653,7 +653,7 @@ static struct my_option my_long_options[ "Base name of shared memory.", (gptr*) &shared_memory_base_name, (gptr*) &shared_memory_base_name, 0, GET_STR_ALLOC, REQUIRED_ARG, 0, 0, 0, 0, 0, 0}, #endif - {"socket", 'S', "Socket file to use for connection. (This will override --port unless --protocol=TCP is specified.)", + {"socket", 'S', "Socket file to use for connection.", (gptr*) &opt_mysql_unix_port, (gptr*) &opt_mysql_unix_port, 0, GET_STR_ALLOC, REQUIRED_ARG, 0, 0, 0, 0, 0, 0}, #include "sslopt-longopts.h" @@ -939,14 +939,7 @@ static int get_options(int argc, char ** opt_reconnect= 0; connect_flag= 0; /* Not in interactive mode */ } - - if (opt_mysql_port && (!opt_protocol) && (!opt_mysql_unix_port)) - { - /* Not checking return type since we are using a constant value */ - /* straight from the initialization of sql_protocol_typelib. */ - opt_protocol= find_type("TCP", &sql_protocol_typelib, 0); - } - + if (strcmp(default_charset, charset_info->csname) && !(charset_info= get_charset_by_csname(default_charset, MY_CS_PRIMARY, MYF(MY_WME))))