On Thu, 2008-07-24 at 14:55 +0200, Kevin Lewis wrote:
> 2755 Kevin Lewis 2008-07-24
> Code Cleanup.
> Make sure all SyncObjects are named correctly.
> Make sure all instances of Sync have a unique name.
> Rename some SyncObject variables for consistency.
> Comment SerialLog::getPageState since it is not used.
> Replace the variable name 'where' with 'location'
> since it is a reserved word.
> If TransactionManager::committedTransactions is locked
> while TransactionManager::activeTransactions is locked,
> committedTransactions must be locked first.
Kevin,
wouldn't it be easier for a reviewer, when the code cleanup and
potential deadlock fix would go into separate change sets?
[cut]
Best regards,
Hakan
--
Hakan Küçükyılmaz, Senior Software Engineer DBTG/MySQL +49 160
98953296
Sun Microsystems GmbH Sonnenallee 1, DE-85551 Kirchheim-Heimstetten
Geschaeftsfuehrer: Thomas Schroeder, Wolfang Engels, Dr. Roland Boemer
Vorsitz d. Aufs.rat.: Martin Haering HRB MUC 161028 49.011, 8.376
