From: Date: July 24 2008 9:15pm
Subject: Re: bzr commit into mysql-4.1 branch (holyfoot:2705) Bug#32167
List-Archive: http://lists.mysql.com/commits/50446
Message-Id: <20080724191504.GA22479@janus.mylan>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

Hi!

On Jul 24, Alexey Botchkov wrote:
> (continuation of the IRC discussion)
>>> +   mi_open_datafile(info,share,NULL,-1))
>>
>> Why you didn't use real name here ?
>>
>> On the other hand, if you'd move the check from mi_open down to
>> mi_open_datafile(), it would cover all cases automatically.
>>
> moving the check to the mi_open_datafile didn't work well for me
> as we don't store the original path in the 'share' structure.
> share->data_file_name contains 'loaded' symlink so i can't use
> my_is_symlink() to identify if we need to check the 'realpath'.
> Storing the 'original' name of the symlink in the share->data_file_name 
> didn't work well also, particularly with the 'SHOW CREATE FILE'.
> So now i plan to keep the check in the mi_open() code and just fixe the
> mi_open_datafile call you noted.
>
> Do you have a different idea?

What about storing the original name of the symlink in
share->data_file_name and calling realpath in SHOW CREATE TABLE to get
the old behavior ?

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring