From: Date: July 23 2008 11:32am
Subject: Re: bzr commit into mysql-4.1 branch (holyfoot:2705) Bug#32167
List-Archive: http://lists.mysql.com/commits/50278
Message-Id: <20080723093248.GA8841@janus.mylan>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit

Hi!

On Jul 23, Alexey Botchkov wrote:
> Sergei,
>
> i'd agree with the suggestions about mi_open_datafile and
> MY_RESOLVE_LINK option, will recommit soon.
>
>>> +#if defined(HAVE_REALPATH) && !defined(HAVE_purify) && 
>>> !defined(HAVE_BROKEN_REALPATH)
>>
>> why this #ifdef ?
> It existed in the old code i copied into this function, so i didn't
> invent it.  Technically i think it disables the 'realpath' call if the
> 'realpath' doesn't exists in the OS or is broken.

Yes, I know that the ifdef existed in my_realpath().

I asked - why you have copied it to is_symlink() ?
lstat() isn't necessarily broken if HAVE_BROKEN_REALPATH, nor, I think,
it has any problems with purify.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer
Vorsitzender des Aufsichtsrates: Martin Häring