From: Date: July 18 2008 8:34pm
Subject: bzr commit into mysql-5.0 branch (timothy.smith:2582) Bug#38180
List-Archive: http://lists.mysql.com/commits/50055
X-Bug: 38180
Message-Id: <20080718183421.D7F648000D@ramayana.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

#At file:///home/tsmith/m/bzr/mysql-5.0.67-release/

 2582 Timothy Smith	2008-07-18 [merge]
      Cherry-pick merge from mysql-5.0.66a-release:
      
        Bug #38180    options are read from ~/my.cnf instead of ~/.my.cnf
        
        Pull out some of unpack_dirname() into normalize_dirname(); this
        new function does not expand "~" to the home directory.  Use this
        function in unpack_dirname(), and use it during init_default_directories()
        to remove duplicate entries without losing track of which directory
        is a user's home dir.
modified:
  include/my_sys.h
  mysys/default.c
  mysys/mf_pack.c

=== modified file 'include/my_sys.h'
--- a/include/my_sys.h	2008-07-10 18:47:53 +0000
+++ b/include/my_sys.h	2008-07-18 18:34:15 +0000
@@ -682,6 +682,7 @@ extern my_string fn_format(my_string to,
 			   const char *form, uint flag);
 extern size_s strlength(const char *str);
 extern void pack_dirname(my_string to,const char *from);
+extern uint normalize_dirname(char * to, const char *from);
 extern uint unpack_dirname(my_string to,const char *from);
 extern uint cleanup_dirname(my_string to,const char *from);
 extern uint system_filename(my_string to,const char *from);

=== modified file 'mysys/default.c'
--- a/mysys/default.c	2008-07-09 10:03:48 +0000
+++ b/mysys/default.c	2008-07-16 22:58:45 +0000
@@ -965,8 +965,7 @@ static int add_directory(MEM_ROOT *alloc
   char *p;
   my_bool err __attribute__((unused));
 
-  /* Normalize directory name */
-  len= unpack_dirname(buf, dir);
+  len= normalize_dirname(buf, dir);
   if (!(p= strmake_root(alloc, buf, len)))
     return 1;  /* Failure */
   /* Should never fail if DEFAULT_DIRS_SIZE is correct size */

=== modified file 'mysys/mf_pack.c'
--- a/mysys/mf_pack.c	2007-12-17 08:13:38 +0000
+++ b/mysys/mf_pack.c	2008-07-16 22:58:45 +0000
@@ -266,22 +266,64 @@ void symdirget(char *dir)
 #endif /* USE_SYMDIR */
 
 
-/*
-  Fixes a directroy name so that can be used by open()
+/**
+  Convert a directory name to a format which can be compared as strings
 
-  SYNOPSIS
-    unpack_dirname()
-    to			result-buffer, FN_REFLEN characters. may be == from
-    from		'Packed' directory name (may contain ~)
-
- IMPLEMENTATION
-  Make that last char of to is '/' if from not empty and
-  from doesn't end in FN_DEVCHAR
-  Uses cleanup_dirname and changes ~/.. to home_dir/..
+  @param to     result buffer, FN_REFLEN chars in length; may be == from
+  @param from   'packed' directory name, in whatever format
+  @returns      size of the normalized name
+
+  @details
+  - Ensures that last char is FN_LIBCHAR, unless it is FN_DEVCHAR
+  - Uses cleanup_dirname
+
+  It does *not* expand ~/ (although, see cleanup_dirname).  Nor does it do
+  any case folding.  All case-insensitive normalization should be done by
+  the caller.
+*/
 
-  Changes a UNIX filename to system filename (replaces / with \ on windows)
+uint normalize_dirname(char *to, const char *from)
+{
+  uint length;
+  char buff[FN_REFLEN];
+  DBUG_ENTER("normalize_dirname");
 
-  RETURN
+  /*
+    Despite the name, this actually converts the name to the system's
+    format (TODO: rip out the non-working VMS stuff and name this
+    properly).
+  */
+  (void) intern_filename(buff, from);
+  length= (uint) strlen(buff);			/* Fix that '/' is last */
+  if (length &&
+#ifdef FN_DEVCHAR
+      buff[length - 1] != FN_DEVCHAR &&
+#endif
+      buff[length - 1] != FN_LIBCHAR && buff[length - 1] != '/')
+  {
+    buff[length]= FN_LIBCHAR;
+    buff[length + 1]= '\0';
+  }
+
+  length=cleanup_dirname(to, buff);
+
+  DBUG_RETURN(length);
+}
+
+
+/**
+  Fixes a directory name so that can be used by open()
+
+  @param to     Result buffer, FN_REFLEN characters. May be == from
+  @param from   'Packed' directory name (may contain ~)
+
+  @details
+  - Uses normalize_dirname()
+  - Expands ~/... to home_dir/...
+  - Resolves MySQL's fake "foo.sym" symbolic directory names (if USE_SYMDIR)
+  - Changes a UNIX filename to system filename (replaces / with \ on windows)
+
+  @returns
    Length of new directory name (= length of to)
 */
 
@@ -291,19 +333,8 @@ uint unpack_dirname(my_string to, const 
   char buff[FN_REFLEN+1+4],*suffix,*tilde_expansion;
   DBUG_ENTER("unpack_dirname");
 
-  (void) intern_filename(buff,from);		/* Change to intern name */
-  length= (uint) strlen(buff);			/* Fix that '/' is last */
-  if (length &&
-#ifdef FN_DEVCHAR
-      buff[length-1] != FN_DEVCHAR &&
-#endif
-      buff[length-1] != FN_LIBCHAR && buff[length-1] != '/')
-  {
-    buff[length]=FN_LIBCHAR;
-    buff[length+1]= '\0';
-  }
+  length= normalize_dirname(buff, from);
 
-  length=cleanup_dirname(buff,buff);
   if (buff[0] == FN_HOMELIB)
   {
     suffix=buff+1; tilde_expansion=expand_tilde(&suffix);