Re: bzr commit into mysql-6.0-falcon branch (hakan:2750)

[Andrey Hristov]

Hakan Kuecuekyilmaz wrote:
> On Do, 2008-07-17 at 15:51 +0200, Vladislav Vaintroub wrote:
>>> -----Original Message-----
>>> From: Hakan Kuecuekyilmaz [mailto:hakan@stripped]
>>> Sent: Thursday, July 17, 2008 3:44 PM
>>> To: Vladislav Vaintroub
>>> Cc: commits@stripped
>>> Subject: RE: bzr commit into mysql-6.0-falcon branch (hakan:2750)
>>>
>>> On Do, 2008-07-17 at 14:37 +0200, Vladislav Vaintroub wrote:
>>>> Why 't1' ? Is 't' not good enough?
>>> t1 is standard name for test tables like t1, t2, t3, t4, ..., tn
>> Please send the link to standardization committee page:)
> 
> It is documented here
> http://dev.mysql.com/doc/mysqltest/en/writing-tests-naming-conventions.html

sometimes the documentation is outdated and what the devs do is always 
one-step ahead.
If you can explain me why sporadic failure will increase if table names 
are unique? Because things are broken now and it will surface when you 
do it the new way?

> - tables are: t1, t2, t3, ..., tn.
> - views are: v1, v2, v3, ..., vn.
> 
> 
>> Can't we enhance standard and allow 't' for tests that use just a single table.
>> This way you may save good 3-4 bytes per each test case.
>>
> 
> I did not write the test case coding style standard. But I am pretty
> sure that you will have my vote, if you want to join the
> TCCSS-committee.
> 
>>>>>  --enable_warnings
>>>>>
>>>>> -
>>>>> -CREATE TABLE t(i int);
>>>>> +CREATE TABLE t1(a int);
>>>> Why 'a' ? Is 'i' not good enough?
>>> a is standard name for fields like a, b, c, d, ...
>> I think a is for "alphanumeric", i.e character fields. I vote 'i' for int, unless
> "standard"
>> forbids me to do it.
> 
> 
> How about using
>   http://en.wikipedia.org/wiki/Hungarian_notation
> 
> It's more precise and mades code much more readable.  For alphanumeric
> fields I am for encoding the length also, like vc50 is varchar(50) and
> if the vc50 is a foreign key than vcFK50 or maybe vc50FK.
> 
> 
>>>>> -   --send insert into t values(1);
>>>>> +   --send insert into t1 values(1), (3), (5), (7) , (11);
>>>> Why many values instead of one?
>>> That's because I wanted to see how many prime numbers I know by heart.
>>
>> Is that all? Not even 13,17,23?
> 
> No, no, no, I wanted to have a prime number amount of prime numbers. 1,
> 3, 5, 7, and 11 are prime number amount of prime numbers. 1, 3, 5, 7,
> 11, 13, 17, and 23 would break it.
> 
>>
> 

Andrey